fix: prevent double-close errors on tcp handle#166
Open
Vvkmnn wants to merge 1 commit intocoder:mainfrom
Open
Conversation
When a connection is interrupted during an async write, the callback
can attempt to close a handle that's already closing, causing:
handle 0x... is already closing
tcp.lua:161-162 correctly guards with is_closing():
if not client.tcp_handle:is_closing() then
client.tcp_handle:close()
end
But client.lua:219,223 was missing this guard. Added the same defensive
check to prevent the race condition.
Vvkmnn
force-pushed
the
fix/handle-double-close
branch
from
0b3bbe0 to
fa0799b
Compare
Vvkmnn
changed the title
|
@Vvkmnn I had this same problem. hope this gets merged |
|
@ThomasK33 is it possible to merge this pr or is there other solutions that are being pursued. I had to fork the repository to address this issue but obviously I'd like to continue to use the original repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a connection is interrupted during an async write, the callback at client.lua:219 can attempt to close a handle that's already closing, causing:
Root Cause
tcp.lua:161-162correctly guards withis_closing():But
client.lua:219,223doesn't use this guard.Fix
Add the same
is_closing()check toclient.luato match the existing pattern.Testing